mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 22714: Added a test to verify that frameworks with equal share get equal number of allocations.
Date Wed, 18 Jun 2014 15:23:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22714/#review46078
-----------------------------------------------------------


Patch looks great!

Reviews applied: [22714]

All tests passed.

- Mesos ReviewBot


On June 18, 2014, 1:48 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22714/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 1:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1187
>     https://issues.apache.org/jira/browse/MESOS-1187
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> I wrote this test because to see if I can repro the issue in MESOS-1187 (there's also
an existing TODO). Unfortunately couldn't repro the behavior, but this would be a good regression
test to have.
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator_tests.cpp 7ad496437cec6238f208225a012030b7f3c8fe84 
>   src/tests/mesos.hpp 0b9b2f9bfc0def5d65fb571816d62d52f3d0cda4 
> 
> Diff: https://reviews.apache.org/r/22714/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message