mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 21667: Ensuring scheduler IDs are unique.
Date Tue, 17 Jun 2014 23:20:33 GMT


> On June 17, 2014, 3:48 p.m., Ben Mahler wrote:
> > src/sched/sched.cpp, line 1092
> > <https://reviews.apache.org/r/21667/diff/3/?file=611904#file611904line1092>
> >
> >     Oh whoops, I think you'll need to pass in the scheduler process PID here for
this change to be useful.

this causes tests to fail. looking into it.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21667/#review46004
-----------------------------------------------------------


On June 17, 2014, 3:15 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21667/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 3:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1374
>     https://issues.apache.org/jira/browse/MESOS-1374
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 6e14f1cf78b9518a04c35f856fa2358a3d72ddcf 
> 
> Diff: https://reviews.apache.org/r/21667/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> Added os::setenv("LIBPROCESS_PORT", "4242") to src/tests/main.cpp and make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message