mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 22686: Net: allow implicit conversion for IP.
Date Tue, 17 Jun 2014 21:39:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22686/#review45993
-----------------------------------------------------------


After discussed with BenH, we agreed that this is pretty dangerous as a user can do:

net::IP ip = 4;

Let's revert this patch and be more explicit! Sorry about that!

- Jie Yu


On June 17, 2014, 7:30 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22686/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 7:30 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Allowing this means we don't have to create a temporary variable for
> very simple purposes. For example, we might have an IP with prefix but
> we want to have another one to output without prefix.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 97215af 
> 
> Diff: https://reviews.apache.org/r/22686/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message