mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 22690: Added flags::parse() overload for ACLs protobuf.
Date Tue, 17 Jun 2014 20:11:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22690/#review45976
-----------------------------------------------------------

Ship it!



src/common/parse.hpp
<https://reviews.apache.org/r/22690/#comment81140>

    Oops!



src/common/type_utils.hpp
<https://reviews.apache.org/r/22690/#comment81141>

    Why not as JSON?


- Benjamin Hindman


On June 17, 2014, 6:46 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22690/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 6:46 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1499
>     https://issues.apache.org/jira/browse/MESOS-1499
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3e623cc0137ea4ae9113f9b47a4fc88281ee96c1 
>   src/authorizer/authorizer.hpp 43e1c3b177c3ea6f4099afbeb0415579b8284cac 
>   src/authorizer/authorizer.cpp c46b31d0f963311e5d646fa16bef51e8ad19c7f2 
>   src/common/parse.hpp PRE-CREATION 
>   src/common/type_utils.hpp 784a808a5e0b78dab24a4806d6f1f9491a2d6d44 
>   src/master/flags.hpp 780e219e81e3df57da197784f67deab2b0de4382 
>   src/tests/master_authorization_tests.cpp 661d67e50c828b1e5e806f68719aef020455abf2 
>   src/tests/mesos.cpp 98a7c3895343b1bc84c13e54d12905de3b431338 
> 
> Diff: https://reviews.apache.org/r/22690/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message