mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 21799: Fixes to enable cgroup + systemd.slice behavior
Date Tue, 17 Jun 2014 18:50:09 GMT


> On June 9, 2014, 5:17 a.m., Ian Downes wrote:
> > src/linux/cgroups.cpp, line 855
> > <https://reviews.apache.org/r/21799/diff/2/?file=602349#file602349line855>
> >
> >     Why is recursively creating the cgroup needed now when it wasn't before?

systemd creates a nested structure.  


> On June 9, 2014, 5:17 a.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/cgroups/mem.cpp, line 98
> > <https://reviews.apache.org/r/21799/diff/2/?file=602350#file602350line98>
> >
> >     Can you pull the mem isolator clean ups into a separate review?

I need to fix Jie's issues 1st, then it makes sense to assess overall impact.  We "could"
but those additions helped in diagnosing what the problems were. 


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21799/#review45052
-----------------------------------------------------------


On June 3, 2014, 1:39 a.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21799/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 1:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-1195
>     https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fixes to enable cgroups to function when initialized via systemd defaults:
> + Fix for co-mounting cpu,cpuacct
> + Fix for nested cgroups_root='system.slice/mesos-slave.service' 
> + Diagnostics to propagate error details.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 21d87a0 
>   src/linux/cgroups.cpp 142ac43 
>   src/slave/containerizer/isolators/cgroups/mem.cpp f2509ad 
> 
> Diff: https://reviews.apache.org/r/21799/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message