mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 22427: Implemented framework API rate limiting.
Date Tue, 17 Jun 2014 01:52:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22427/#review45884
-----------------------------------------------------------

Ship it!



src/master/master.hpp
<https://reviews.apache.org/r/22427/#comment80960>

    s/Note:/NOTE:/



src/master/master.cpp
<https://reviews.apache.org/r/22427/#comment80961>

    s/max_qps/qps/.
    
    also print the value?



src/master/master.cpp
<https://reviews.apache.org/r/22427/#comment80962>

    kill the 'if'. If the flag is specified, log that rate limiting is enabled.



src/master/master.cpp
<https://reviews.apache.org/r/22427/#comment80963>

    How about,
    
    The framework is not throttled if:
    1) the principal is not specified by the framework (or)
    2) the principal doesn't exist in rate limits (or)
    3) the principal exists in rate limits but 'qps' is not set.



src/master/master.cpp
<https://reviews.apache.org/r/22427/#comment80964>

    You can just point to the above comment for details.



src/master/master.cpp
<https://reviews.apache.org/r/22427/#comment80965>

    single quotes.



src/master/master.cpp
<https://reviews.apache.org/r/22427/#comment80966>

    singe quotes.


- Vinod Kone


On June 17, 2014, 12:48 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22427/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 12:48 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1444
>     https://issues.apache.org/jira/browse/MESOS-1444
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> To simplify the implementation, RateLimiters are added statically during initialize()
and never removed.
> 
> visit(MessageEvent) and visit(ExitedEvent) are throttled together to keep their order
intact.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 
>   src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 
>   src/tests/rate_limiting_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22427/diff/
> 
> 
> Testing
> -------
> 
> Added a test for MESOS-1444. Will add more for MESOS-1445
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message