mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.
Date Mon, 16 Jun 2014 19:48:46 GMT


> On June 16, 2014, 10:39 a.m., Dominic Hamon wrote:
> > src/master/master.cpp, line 763
> > <https://reviews.apache.org/r/22316/diff/5/?file=609679#file609679line763>
> >
> >     is this simpler?
> >     
> >     metrics.frameworks.get(principal.get()).get()->messages_received++;
> >     
> >

I made a copy here because otherwise I would be incrementing a member of a readonly object.
frameworks.get() returns an Option, whose get() returns a "const T&".


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22316/#review45779
-----------------------------------------------------------


On June 13, 2014, 3:48 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22316/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 3:48 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
> 
> 
> Bugs: MESOS-1339
>     https://issues.apache.org/jira/browse/MESOS-1339
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> - Multiple frameworks use the same principal use the same counter.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c91b438c3401ff815116d6faab4f0a34bc0fe3fd 
>   src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 
>   src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 
>   src/tests/rate_limiting_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22316/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message