mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 20963: Add a cgroup perf_event isolator.
Date Thu, 12 Jun 2014 21:50:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20963/
-----------------------------------------------------------

(Updated June 12, 2014, 9:50 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

i'll shepherd this -- vinod.


Repository: mesos-git


Description
-------

This isolator only creates the perf_event cgroup and places the executor into the cgroup;
no performance statistics are gathered/exported.

NOTE: The recover() as implemented is "non-strict"; it will happily recover containers even
if they don't have a perf_event cgroup present. This permits restarting the slave to add this
isolator. Existing containers will not be isolated. New containers will be isolated.


Diffs
-----

  src/Makefile.am 4a3f2e12643a1f02284587ebcbe9374f416b3d60 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp PRE-CREATION 
  src/slave/containerizer/isolators/cgroups/perf_event.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/20963/diff/


Testing
-------

Manually tested.

Our current testing code does not easily permit testing different combinations of isolators
for the MesosContainerizer.


Thanks,

Ian Downes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message