mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 22427: Implemented framework API rate limiting.
Date Thu, 12 Jun 2014 15:28:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22427/#review45504
-----------------------------------------------------------


Bad patch!

Reviews applied: [22424, 22426, 22425, 22427]

Failed command: git apply --index 22427.patch

Error:
 error: patch failed: src/master/master.cpp:797
error: src/master/master.cpp: patch does not apply
error: src/tests/rate_limiting_tests.cpp: does not exist in index


- Mesos ReviewBot


On June 11, 2014, 5:39 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22427/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 5:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1444
>     https://issues.apache.org/jira/browse/MESOS-1444
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> To simplify the implementation, RateLimiters are added statically during initialize()
and never removed.
> 
> visit(MessageEvent) and visit(ExitedEvent) are throttled together to keep their order
intact.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 
>   src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 
>   src/tests/rate_limiting_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22427/diff/
> 
> 
> Testing
> -------
> 
> Added a test for MESOS-1444. Will add more for MESOS-1445
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message