mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 22316: Added "per-framework-principal" counters for messages from a scheduler to the master.
Date Tue, 10 Jun 2014 18:04:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22316/
-----------------------------------------------------------

(Updated June 10, 2014, 11:04 a.m.)


Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.


Changes
-------

- Add one more counter, now we have 
  frameworks/principal/messages_received
  frameworks/principal/messages_processed

- Revised the implemented to use these two maps to locate the counters.
  map[UPID] -> principal
  map[principal] -> counter

- Moved tests to a separate file where rate limiting tests will also be added (either as separate
tests or added to the counters tests)


Bugs: MESOS-1339
    https://issues.apache.org/jira/browse/MESOS-1339


Repository: mesos-git


Description (updated)
-------

- Multiple frameworks use the same principal use the same counter.


Diffs (updated)
-----

  src/Makefile.am 4a3f2e12643a1f02284587ebcbe9374f416b3d60 
  src/master/master.hpp 26af1139a43a62b91712acd158b24a8977c81d3f 
  src/master/master.cpp c18ccc4a1770cd68e4c3cb4b5f8ab912515ab613 
  src/tests/rate_limiting_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/22316/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message