mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 21734: MESOS-390 Handle file:// in fetcher
Date Mon, 09 Jun 2014 20:32:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21734/#review45129
-----------------------------------------------------------


Bad patch!

Reviews applied: [21734]

Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null

Error:
 configure: WARNING: can not find python-boto
-------------------------------------------------------------------
mesos-ec2 services will not function.
-------------------------------------------------------------------
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by
default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result
[-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result
[-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result
[-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result
[-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
                 from src/glog/stl_logging.h:54,
                 from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This file includes
at least one deprecated or antiquated header which may be removed without further notice at
a future date. Please use a non-deprecated interface with equivalent functionality instead.
For a listing of replacement headers and interfaces, consult the file backward_warning.h.
To disable this warning use -Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
                 from src/googletest.h:38,
                 from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
ar: creating libleveldb.a
zip_safe flag not set; analyzing archive contents...
WARNING: '.' not a valid package name; please use only.-separated package names in setup.py
package init file 'src/__init__.py' not found (or not a regular file)
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not
for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not
for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not
for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not
for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not
for C++ [enabled by default]
zip_safe flag not set; analyzing archive contents...
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
../../src/tests/fetcher_tests.cpp:73:40: sorry, unimplemented: non-static data member initializers
../../src/tests/fetcher_tests.cpp:73:40: error: in-class initialization of static data member
'ASSETS_DIRECTORY_NAME' of non-literal type
../../src/tests/fetcher_tests.cpp:74:31: sorry, unimplemented: non-static data member initializers
../../src/tests/fetcher_tests.cpp:74:31: error: in-class initialization of static data member
'COMMAND_NAME' of non-literal type
../../src/tests/fetcher_tests.cpp:76:44: error: 'COMMAND_NAME' was not declared in this scope
../../src/tests/fetcher_tests.cpp:76:44: sorry, unimplemented: non-static data member initializers
../../src/tests/fetcher_tests.cpp:76:44: error: in-class initialization of static data member
'COMMAND_SCRIPT' of non-literal type
../../src/tests/fetcher_tests.cpp:95:57: error: temporary of non-literal type 'Try<process::PID<mesos::internal::slave::Slave>
>' in a constant expression
../../src/tests/fetcher_tests.cpp:95:57: sorry, unimplemented: non-static data member initializers
../../src/tests/fetcher_tests.cpp:95:57: error: in-class initialization of static data member
'slavePid' of non-literal type
../../src/tests/fetcher_tests.cpp:98:34: sorry, unimplemented: non-static data member initializers
../../src/tests/fetcher_tests.cpp:98:34: error: 'constexpr' needed for in-class initialization
of static data member 'driver' of non-integral type
../../src/tests/fetcher_tests.cpp: In constructor 'FetcherTest::FetcherTest()':
../../src/tests/fetcher_tests.cpp:84:50: error: 'ASSETS_DIRECTORY_NAME' was not declared in
this scope
../../src/tests/fetcher_tests.cpp: In member function 'void FetcherTest::setupCommandFileAsset()':
../../src/tests/fetcher_tests.cpp:107:45: error: 'COMMAND_NAME' was not declared in this scope
../../src/tests/fetcher_tests.cpp:108:3: error: 'COMMAND_SCRIPT' was not declared in this
scope
../../src/tests/fetcher_tests.cpp: In member function 'void FetcherTest::startMesos()':
../../src/tests/fetcher_tests.cpp:116:3: error: 'slavePid' was not declared in this scope
../../src/tests/fetcher_tests.cpp:129:3: error: 'driver' was not declared in this scope
../../src/tests/fetcher_tests.cpp: In member function 'void FetcherTest::stopSlave()':
../../src/tests/fetcher_tests.cpp:141:8: error: 'slavePid' was not declared in this scope
../../src/tests/fetcher_tests.cpp: In member function 'void FetcherTest::stopMesos()':
../../src/tests/fetcher_tests.cpp:147:3: error: 'driver' was not declared in this scope
../../src/tests/fetcher_tests.cpp:149:10: error: type '<type error>' argument given
to 'delete', expected pointer
../../src/tests/fetcher_tests.cpp: In member function 'virtual void FetcherTest_FileURI_Test::TestBody()':
../../src/tests/fetcher_tests.cpp:162:32: error: 'COMMAND_NAME' was not declared in this scope
../../src/tests/fetcher_tests.cpp:167:5: error: 'driver' was not declared in this scope
../../src/tests/fetcher_tests.cpp: In member function 'virtual void FetcherTest_FileLocalhostURI_Test::TestBody()':
../../src/tests/fetcher_tests.cpp:229:32: error: 'COMMAND_NAME' was not declared in this scope
../../src/tests/fetcher_tests.cpp:234:3: error: 'driver' was not declared in this scope
make[4]: *** [tests/mesos_tests-fetcher_tests.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [check-am] Error 2
make[2]: *** [check] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [distcheck] Error 1


- Mesos ReviewBot


On June 9, 2014, 6:36 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21734/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 6:36 p.m.)
> 
> 
> Review request for mesos, Adam B and Niklas Nielsen.
> 
> 
> Bugs: MESOS-390
>     https://issues.apache.org/jira/browse/MESOS-390
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Handling file:// in the fetcher, and also handle case when localhost is used.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 4a3f2e1 
>   src/launcher/fetcher.cpp c4425eb 
>   src/tests/fetcher_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21734/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests to test file:// and file://localhost.
> make check.
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message