mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 22268: Added "implicit" reconciliation.
Date Fri, 06 Jun 2014 22:27:46 GMT


> On June 6, 2014, 8:02 p.m., Vinod Kone wrote:
> >

I'll also update the documentation for the Java API, filed MESOS-1461 to get reconciliation
added to the Python API.


> On June 6, 2014, 8:02 p.m., Vinod Kone wrote:
> > include/mesos/scheduler.hpp, line 314
> > <https://reviews.apache.org/r/22268/diff/1/?file=604057#file604057line314>
> >
> >     s/task/non-terminal task/ ?
> >     
> >     or is the plan to send all unacknowledged tasks in the future once acks go through
the master?

Good point, I updated the documentation to imply that the framework should only be asking
about non-terminal tasks.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22268/#review44956
-----------------------------------------------------------


On June 5, 2014, 5:35 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22268/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 5:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1379
>     https://issues.apache.org/jira/browse/MESOS-1379
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Currently frameworks must ask to reconcile a set of tasks explicitly, this means that
the tasks must be known to the framework.
> 
> In some cases, the framework may lose the information about a particular task (bugs,
data loss, etc). When this occurs, we do not provide a mechanism for the state to be reconciled.
> 
> That is, the non-terminal tasks known to the Master / Slave that are unknown to the framework
will remain running. Status updates from these tasks are the only way that frameworks will
be informed of these tasks. This patch introduces the notion of an "implicit" reconciliation
request where the framework does not ask about any explicit tasks. In this case, the master
replies with all tasks currently known.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp a17db5919f8c434a918bf5f782ef5e02c5a9be9c 
>   include/mesos/scheduler/scheduler.proto 4deda5598d9c242f97659d06309294f24f7cfd8a 
>   src/master/master.cpp 91dc1fd85ed83913ab5c7542a96a9d71160b4f94 
>   src/messages/messages.proto 6f6e570b1018d8c54d4b8d811470086832792ec4 
>   src/tests/reconciliation_tests.cpp 677d18e1a4e1683809d21eb96bab48d6e3868207 
> 
> Diff: https://reviews.apache.org/r/22268/diff/
> 
> 
> Testing
> -------
> 
> Added two tests for implicit reconciliation.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message