mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 22253: Wait on Containerizer::update to complete before sending status update.
Date Fri, 06 Jun 2014 19:40:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22253/#review44953
-----------------------------------------------------------


can you add a couple tests here?

1) containerizer->update() fails
2) executor exited / container destroyed before _statusUpdate() is processed


src/slave/slave.cpp
<https://reviews.apache.org/r/22253/#comment79543>

    can you print executor id and task id too?


- Vinod Kone


On June 4, 2014, 11:37 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22253/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 11:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1417
>     https://issues.apache.org/jira/browse/MESOS-1417
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Wait on Containerizer::update to complete before sending status update.
> 
> If the update fails the container will be destroyed.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 34687e555e6ba07863c45840aa6d07717388cf62 
>   src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368 
>   src/tests/status_update_manager_tests.cpp c753921194a3ae449feff0b20dfc058b6e086528

> 
> Diff: https://reviews.apache.org/r/22253/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message