mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 22248: Allowed parsing JSON array flags.
Date Wed, 04 Jun 2014 22:32:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22248/#review44766
-----------------------------------------------------------


What was the motivation for this patch?

- Ben Mahler


On June 4, 2014, 10:29 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22248/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 10:29 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. I did try to use enable_if to make 'parse' more generic to all JSON values,
but its more complicated than I thought. The main reason is because we use lambda::bind(&parse<T>,
...) in 'add(...)' function. The compiler is not quite smart enough to figure out the right
overload when doing 'lambda::bind'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 1209469 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 
> 
> Diff: https://reviews.apache.org/r/22248/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message