mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 21713: Route overload to add auth HTTP Response + tests
Date Tue, 03 Jun 2014 17:29:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21713/#review44643
-----------------------------------------------------------


Great stuff. Just a couple of comments from me.


3rdparty/libprocess/include/process/process.hpp
<https://reviews.apache.org/r/21713/#comment79057>

    Or you could default to an empty vector, and treat that as no authorization.



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/21713/#comment79055>

    name vs. name.substr(1)?



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/21713/#comment79056>

    name vs. name.substr(1)?



3rdparty/libprocess/src/tests/http_tests.cpp
<https://reviews.apache.org/r/21713/#comment79058>

    auth2 is only expected to actually be called for the "right auth header"? If so, put the
expectation down by that section.


- Adam B


On May 20, 2014, 10:20 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21713/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 10:20 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
> 
> 
> Bugs: MESOS-1131
>     https://issues.apache.org/jira/browse/MESOS-1131
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Depends on : https://reviews.apache.org/r/21324/
> 3rd phase following Ben's comments on https://reviews.apache.org/r/19575/
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 1f0944a 
>   3rdparty/libprocess/include/process/process.hpp c29cd21 
>   3rdparty/libprocess/src/process.cpp 58bae5b 
>   3rdparty/libprocess/src/tests/http_tests.cpp f58a129 
> 
> Diff: https://reviews.apache.org/r/21713/diff/
> 
> 
> Testing
> -------
> 
> Make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message