mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 22162: Pulled common Framework (re-)registration validation into a helper method.
Date Tue, 03 Jun 2014 05:28:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22162/#review44600
-----------------------------------------------------------



src/master/master.cpp
<https://reviews.apache.org/r/22162/#comment79021>

    Why an Option<Error> instead of a Try?



src/master/master.cpp
<https://reviews.apache.org/r/22162/#comment79022>

    The "Framework is not authenticated" error is not "due to invalid FrameworkInfo".


- Adam B


On June 2, 2014, 9:33 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22162/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 9:33 p.m.)
> 
> 
> Review request for mesos, Dominic Hamon and Vinod Kone.
> 
> 
> Bugs: MESOS-1373
>     https://issues.apache.org/jira/browse/MESOS-1373
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is a follow up for https://reviews.apache.org/r/21787.
> There exists duplication of logic in (re)-registerFramework methods.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp d4ef4bec7168179f2168e88d3727e50b0e2e68a1 
>   src/master/master.cpp 766a0e36a6e7a615e7b2974d9fee70bcef446719 
> 
> Diff: https://reviews.apache.org/r/22162/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message