mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 22150: Injected Authorizer into Master.
Date Mon, 02 Jun 2014 18:39:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22150/#review44524
-----------------------------------------------------------



src/local/local.cpp
<https://reviews.apache.org/r/22150/#comment78935>

    it might be better to keep authorizer as Owned and pass in authorizer.get() here. Then
you don't need the explicit authorizer delete below.



src/master/main.cpp
<https://reviews.apache.org/r/22150/#comment78936>

    ditto re Owned::get



src/master/master.hpp
<https://reviews.apache.org/r/22150/#comment78937>

    what's the conceptual difference between an Option<T*> and a T* that can be NULL?


- Dominic Hamon


On June 2, 2014, 11:01 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22150/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 11:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Injected the Authorizer so that I can write more interesting tests.
> 
> 
> Diffs
> -----
> 
>   src/local/local.cpp 5d26afffcdca0eb9d19499564a8edd2bf3dc1e66 
>   src/master/main.cpp 8ceaae61a732a8d68d19c8aee97c1fd93a595893 
>   src/master/master.hpp d4ef4bec7168179f2168e88d3727e50b0e2e68a1 
>   src/master/master.cpp 766a0e36a6e7a615e7b2974d9fee70bcef446719 
>   src/tests/cluster.hpp f4cc9a62cd0ca86cd87987d963abd951a377ddd1 
> 
> Diff: https://reviews.apache.org/r/22150/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message