Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============3370699385837384306=="
MIME-Version: 1.0
Subject: Re: Review Request 19545: Ported libprocess system/stats.json
 endpoint to
 new metrics library.
From: "Dominic Hamon" <dhamon@twopensource.com>
To: "Ben Mahler" <benjamin.mahler@gmail.com>
Cc: "Dominic Hamon" <dhamon@twopensource.com>, "mesos" <dev@mesos.apache.org>,
 "Vinod Kone" <vinodkone@gmail.com>
Date: Tue, 27 May 2014 17:49:57 -0000
Message-ID: <20140527174957.12586.23163@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dominic Hamon" <noreply@reviews.apache.org>
References: <20140527173812.12584.97818@reviews.apache.org>
In-Reply-To: <20140527173812.12584.97818@reviews.apache.org>
Reply-To: "Dominic Hamon" <dhamon@twopensource.com>

--===============3370699385837384306==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On May 27, 2014, 10:38 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/include/process/system.hpp, lines 81-85
> > <https://reviews.apache.org/r/19545/diff/13/?file=588085#file588085line81>
> >
> >     I know you just moved this, but the "avg_" prefix seems wrong? the metrics names don't have that prefix. also, there is no mention of mem_total_bytes and mem_free_bytes?

nice catch - i didn't even notice.


> On May 27, 2014, 10:38 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/src/tests/system_tests.cpp, lines 32-56
> > <https://reviews.apache.org/r/19545/diff/13/?file=588087#file588087line32>
> >
> >     the "tests/system_tests.cpp" seems a bit misleading. just add this test to the metrics_tests file as this is just the default metrics process behavior.

I added this because the MetricsInStatsEndpoint tests are in master_tests and slave_tests. This isn't testing the metrics process, it's testing that the API of the system process metrics hasn't changed. As such, it should probably be in a system_tests file.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545/#review43993
-----------------------------------------------------------


On May 27, 2014, 10:49 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19545/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 10:49 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1146
>     https://issues.apache.org/jira/browse/MESOS-1146
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am fa9b4fd0bb2555c3372151f8b86c8a6457319d93 
>   3rdparty/libprocess/include/process/system.hpp fbd1eaa1de44eb419cef4c78efd6d138eabc7b44 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 8a131218b858a6571bd520c470eac850a3fd345e 
>   3rdparty/libprocess/src/tests/system_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19545/diff/
> 
> 
> Testing
> -------
> 
> make check and manually checked /system/stats.json against /metrics
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


--===============3370699385837384306==--