Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09DAE11339 for ; Wed, 14 May 2014 22:14:38 +0000 (UTC) Received: (qmail 37929 invoked by uid 500); 10 May 2014 22:43:56 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 37369 invoked by uid 500); 10 May 2014 22:43:54 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 36964 invoked by uid 99); 10 May 2014 22:43:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2014 22:43:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E06261D7658; Thu, 8 May 2014 23:28:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8354478403086582214==" MIME-Version: 1.0 Subject: Re: Review Request 20995: Allow Gauge to take simple functions. From: "Dominic Hamon" To: "Ben Mahler" Cc: "Mesos ReviewBot" , "Dominic Hamon" , "mesos" Date: Thu, 08 May 2014 23:28:14 -0000 Message-ID: <20140508232814.25724.9156@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dominic Hamon" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/20995/ X-Sender: "Dominic Hamon" References: <20140502195218.17845.8820@reviews.apache.org> In-Reply-To: <20140502195218.17845.8820@reviews.apache.org> Reply-To: "Dominic Hamon" X-ReviewRequest-Repository: mesos-git --===============8354478403086582214== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20995/ ----------------------------------------------------------- (Updated May 8, 2014, 4:28 p.m.) Review request for mesos and Ben Mahler. Changes ------- Added second constructor instead of replacing it. Summary (updated) ----------------- Allow Gauge to take simple functions. Bugs: MESOS-1286 https://issues.apache.org/jira/browse/MESOS-1286 Repository: mesos-git Description ------- see summary. This allows synchronous Gauge methods which reduces potential process queue pressure. Diffs (updated) ----- 3rdparty/libprocess/include/process/metrics/gauge.hpp af06534622b3f00c1d1dc5c577527375318fd79a 3rdparty/libprocess/src/tests/metrics_tests.cpp 8a131218b858a6571bd520c470eac850a3fd345e Diff: https://reviews.apache.org/r/20995/diff/ Testing ------- make check Thanks, Dominic Hamon --===============8354478403086582214==--