Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3637411596 for ; Sun, 11 May 2014 04:27:55 +0000 (UTC) Received: (qmail 30321 invoked by uid 500); 10 May 2014 23:28:31 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 78149 invoked by uid 500); 10 May 2014 23:17:27 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 5263 invoked by uid 99); 10 May 2014 23:03:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2014 23:03:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0F59A1D79BA; Thu, 8 May 2014 21:57:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5832801453485185485==" MIME-Version: 1.0 Subject: Re: Review Request 21236: Fixed tasks reconciliation and added tests. From: "Ben Mahler" To: "Dominic Hamon" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Thu, 08 May 2014 21:57:06 -0000 Message-ID: <20140508215706.18889.66203@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/21236/ X-Sender: "Ben Mahler" References: <20140508210941.25724.17371@reviews.apache.org> In-Reply-To: <20140508210941.25724.17371@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos-git --===============5832801453485185485== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21236/#review42540 ----------------------------------------------------------- Ship it! Glad we found this bug! src/master/master.cpp Can you s/best-effort// before you commit this? src/master/master.cpp Should this say unknown as well? src/tests/reconciliation_tests.cpp Hm.. status and status2 are a bit confusing, maybe s/status/update/ and s/status2/status/? Ditto below src/tests/reconciliation_tests.cpp s/strict/non-strict/ src/tests/reconciliation_tests.cpp Could you also add a similar TODO at _reregisterSlave in master.hpp? I just want to make sure it's clear what could be done to move it back to private :) - Ben Mahler On May 8, 2014, 9:09 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21236/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 9:09 p.m.) > > > Review request for mesos, Ben Mahler and Dominic Hamon. > > > Bugs: MESOS-1320 > https://issues.apache.org/jira/browse/MESOS-1320 > > > Repository: mesos-git > > > Description > ------- > > Fixed reconciliation so that status updates are always sent. > > > Diffs > ----- > > src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e > src/master/master.cpp 87ea77aa19e482a20f081061e81acc89582eacdd > src/tests/reconciliation_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21236/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > > --===============5832801453485185485==--