Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 18A7911D2D for ; Sun, 11 May 2014 15:45:15 +0000 (UTC) Received: (qmail 980 invoked by uid 500); 10 May 2014 22:56:26 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 73624 invoked by uid 500); 10 May 2014 22:54:43 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 61457 invoked by uid 99); 10 May 2014 22:53:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2014 22:53:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 84FBA1D797C; Thu, 8 May 2014 20:08:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4642189220974735238==" MIME-Version: 1.0 Subject: Re: Review Request 21233: Abstracted out invoking 'mesos-fetcher'. From: "Dominic Hamon" To: "Tom Arnfeld" , "Dominic Hamon" , "Ian Downes" , "Vinod Kone" Cc: "Benjamin Hindman" , "mesos" Date: Thu, 08 May 2014 20:08:38 -0000 Message-ID: <20140508200838.25724.10976@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dominic Hamon" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/21233/ X-Sender: "Dominic Hamon" References: <20140508191602.28778.41968@reviews.apache.org> In-Reply-To: <20140508191602.28778.41968@reviews.apache.org> Reply-To: "Dominic Hamon" X-ReviewRequest-Repository: mesos-git --===============4642189220974735238== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21233/#review42535 ----------------------------------------------------------- src/slave/fetcher.hpp now this is in its own file, why not add a fetcher.cpp for the definitions and minimize the amount of inline code + includes we have to process? src/slave/fetcher.hpp this redirection could be a separate method to avoid the repeated code. - Dominic Hamon On May 8, 2014, 12:16 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21233/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 12:16 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, Tom Arnfeld, and Vinod Kone. > > > Bugs: MESOS-1316 > https://issues.apache.org/jira/browse/MESOS-1316 > > > Repository: mesos-git > > > Description > ------- > > To test the mesos-fetcher (and the setting of the environment) more cleanly I did some refactoring into a 'fetcher' namespace. > > > Diffs > ----- > > src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029 > src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 > src/slave/containerizer/mesos_containerizer.cpp 2a4816ec34f2298b71e8591c1e92d77f94ef4cb3 > src/slave/fetcher.hpp PRE-CREATION > src/tests/containerizer_tests.cpp 9d20853bcc1965adc2d9ea41044b5613cd992f11 > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21233/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > > --===============4642189220974735238==--