mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-1291) Use clang-format to automatically format code to style
Date Mon, 05 May 2014 17:18:17 GMT

    [ https://issues.apache.org/jira/browse/MESOS-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989718#comment-13989718
] 

Benjamin Hindman commented on MESOS-1291:
-----------------------------------------

SGTM!

> Use clang-format to automatically format code to style
> ------------------------------------------------------
>
>                 Key: MESOS-1291
>                 URL: https://issues.apache.org/jira/browse/MESOS-1291
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Dominic Hamon
>              Labels: style
>
> Instead of relying on a script to check and report style errors, we should move to a
workflow that allows people to write code how they feel comfortable and then automatically
format it to conform to our style guide.
> The Chromium style from clang-format (http://clang.llvm.org/docs/ClangFormat.html) is
very close to our style except for the dropped braces on class, struct, and function definitions,
and two lines of whitespace between method definitions outside a class. As such, we should
consider adopting clang-format and patching it to include a Mesos style variant.
> It can be run as part of post-reviews or as a git commit hook, or manually from within
editors.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message