mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yifan Gu" <yi...@mesosphere.io>
Subject Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.
Date Thu, 29 May 2014 22:35:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21968/
-----------------------------------------------------------

(Updated May 29, 2014, 10:35 p.m.)


Review request for mesos, Adam B and Niklas Nielsen.


Bugs: MESOS-878
    https://issues.apache.org/jira/browse/MESOS-878


Repository: mesos-git


Description
-------

Added a sentence to check the slave's state in doReliableRegistration() to make sure that
the function returns when the slave's state is TERMINATING.
Also, to write the test, I need to make sure there's no additional doReliableRegistration()
calls, so I added NO_FUTURE_PROTOBUFS() and NO_FUTURE_MESSAGES() to make sure there's no more
SlaveReregisteredMessages.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/gmock.hpp daba7e3 
  src/slave/slave.cpp 7fbedb1 
  src/tests/mesos.hpp 1b0f358 
  src/tests/slave_tests.cpp 80fe3cf 

Diff: https://reviews.apache.org/r/21968/diff/


Testing
-------

Slave_tests.cpp:TerminatingSlaveDoesNotReregister.


Thanks,

Yifan Gu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message