mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 21966: Fixed ExternalContainerizer fd leak and premature close.
Date Thu, 29 May 2014 02:41:24 GMT


> On May 29, 2014, 2:37 a.m., Benjamin Hindman wrote:
> > src/slave/containerizer/external_containerizer.cpp, line 1125
> > <https://reviews.apache.org/r/21966/diff/3/?file=598213#file598213line1125>
> >
> >     You could not bother setting the close-on-exec flag and just close it immediately
after doing the io::redirect rather than via an onAny. It's slightly more exposed to a fork
but not too much (and it's just less code in general). You could move the TODO up to the open
then.

Aye, makes sense - will fix that here and in the MC RR as well.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21966/#review44227
-----------------------------------------------------------


On May 29, 2014, 2:31 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21966/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 2:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1431
>     https://issues.apache.org/jira/browse/MESOS-1431
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.cpp b39c845 
> 
> Diff: https://reviews.apache.org/r/21966/diff/
> 
> 
> Testing
> -------
> 
> make check as well as Deimos (ECP) intergration tests
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message