mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 21829: Uninlined large function from usage.hpp
Date Tue, 27 May 2014 22:02:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21829/#review44056
-----------------------------------------------------------

Ship it!



src/usage/usage.cpp
<https://reviews.apache.org/r/21829/#comment78366>

    Kill this. The same comment exists in the header file.


- Vinod Kone


On May 22, 2014, 9:51 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21829/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 9:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1412
>     https://issues.apache.org/jira/browse/MESOS-1412
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary. This also causes problems when building executables that link against libmesos
and include mesos_containerizer.hpp
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2 
>   src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246 
>   src/usage/usage.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21829/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message