mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.
Date Tue, 27 May 2014 21:50:33 GMT


> On May 27, 2014, 2:48 p.m., Ian Downes wrote:
> > src/tests/containerizer_tests.cpp, line 462
> > <https://reviews.apache.org/r/21833/diff/1/?file=588592#file588592line462>
> >
> >     Let's change this to use printf, as suggested in `man echo`, to not output the
\n.
> 
> Dominic Hamon wrote:
>     looking over the rest of the code, we use 'echo' and compare with the '\n'. for consistency
maybe leaving this as echo is better?

works for me! :-)


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/#review44047
-----------------------------------------------------------


On May 22, 2014, 5:47 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21833/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 5:47 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1413
>     https://issues.apache.org/jira/browse/MESOS-1413
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer_tests.cpp 2f4888d 
> 
> Diff: https://reviews.apache.org/r/21833/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX and linux)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message