mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 21558: Expose event queue size from SchedulerProcess
Date Tue, 27 May 2014 17:44:13 GMT


> On May 21, 2014, 11:02 p.m., Vinod Kone wrote:
> > src/sched/sched.cpp, line 1011
> > <https://reviews.apache.org/r/21558/diff/1/?file=583759#file583759line1011>
> >
> >     In our tests that bring up multiple schedulers (e.g., fault tolerance) is this
safe? Doesn't this metric collide?
> 
> Dominic Hamon wrote:
>     currently we don't check the return value of 'add'. What will be happening is that
'add' would return a Failure the second time it is called.
>     
>     when 20987 lands, we can use self().id instead of scheduler/ as a prefix which would
be safe. the metrics would be:
>     
>     scheduler/event_queue_size
>     scheduler/1/event_queue_size
>     scheduler/2/event_queue_size
>     ...
>

Can you add a TODO reflecting what you just said? It lets us keep track and cleanup in the
future.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21558/#review43665
-----------------------------------------------------------


On May 16, 2014, 10:33 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21558/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 10:33 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1371
>     https://issues.apache.org/jira/browse/MESOS-1371
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2 
>   src/sched/sched.cpp 3684cfe9d153cab5f4ea86094fffd814ce74baa1 
>   src/tests/scheduler_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21558/diff/
> 
> 
> Testing
> -------
> 
> add test and make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message