mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.
Date Sun, 25 May 2014 16:03:05 GMT


> On May 24, 2014, 9:09 p.m., Niklas Nielsen wrote:
> > Modulo a clarifying comment.
> 
> Niklas Nielsen wrote:
>     Just took this patch for a spin and I am running into problems with EC recovery during
startup. Would you mind reaching out before committing?

Thanks for doing that double check. I am now testing it again and also trying to reach you
on the usual channels...


> On May 24, 2014, 9:09 p.m., Niklas Nielsen wrote:
> > src/slave/containerizer/external_containerizer.cpp, lines 423-427
> > <https://reviews.apache.org/r/21424/diff/4/?file=592590#file592590line423>
> >
> >     collect() returns Future<Nothing> and when we don't do anything with the
future in the continuation (other than a log message), how about flattening it?

Ow good point indeed, thanks!


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21424/#review43901
-----------------------------------------------------------


On May 24, 2014, 12:14 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21424/
> -----------------------------------------------------------
> 
> (Updated May 24, 2014, 12:14 a.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1364
>     https://issues.apache.org/jira/browse/MESOS-1364
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> An orphaned container is known to the ECP but not to the EC, thus not recoverable but
pending. This patch enforces a call to destroy for any orphan that has been identified as
such during the recovery phase.
> 
> NOTE: Such destroy is wrapped by a call to "wait" to make sure the ExternalContainerizer
gets to know when a container was destroyed successfully.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 7e5474c 
>   src/slave/containerizer/external_containerizer.cpp ac3dd18 
> 
> Diff: https://reviews.apache.org/r/21424/diff/
> 
> 
> Testing
> -------
> 
> make check against upcoming SlaveRecoveryTests (enabled locally)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message