mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 21777: Explicit conversion to Result<> from Unreachable to squash compiler error.
Date Thu, 22 May 2014 21:07:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21777/#review43772
-----------------------------------------------------------

Ship it!


I've committed this, I'll let benh follow up if there's a cleaner solution that would be preferred.

- Ben Mahler


On May 21, 2014, 6:37 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21777/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 6:37 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> Without the explicit conversion some compilers find the conversion from Unreachable()
to Result<T>() ambiguous.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 94d8b4c7fcf83946e2f9dd0f3e746889599ca174

> 
> Diff: https://reviews.apache.org/r/21777/diff/
> 
> 
> Testing
> -------
> 
> able to build on clang 3.4
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message