mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 21787: Keep track of the principals for authenticated pids in Master and verify FramworkInfo::principal during (re-)registration.
Date Thu, 22 May 2014 00:18:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21787/#review43680
-----------------------------------------------------------



src/master/master.hpp
<https://reviews.apache.org/r/21787/#comment77973>

    Can we update the comment to mention that the value mapped to is the 'principal' please?


- Benjamin Hindman


On May 21, 2014, 10:01 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21787/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 10:01 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1373
>     https://issues.apache.org/jira/browse/MESOS-1373
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This will be used to 'Add "per-framework-principal" counters for all messages from a
scheduler on Master': https://issues.apache.org/jira/browse/MESOS-1339
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8012873f853fdee47f8cb2f5d9dbb7cd8ccc6028 
>   src/master/master.hpp 5e0d712de997bd10079655df9b07099284f8257f 
>   src/master/master.cpp 075755cad5c50a57c92d7d82f2466b467796f673 
>   src/tests/authentication_tests.cpp b60e595216c2b854adf048002a0d88b548e1d92e 
>   src/tests/mesos.hpp a1a7d7991c4cdb7a994218602fe4e5d76c056456 
> 
> Diff: https://reviews.apache.org/r/21787/diff/
> 
> 
> Testing
> -------
> 
> Added tests. Make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message