mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.
Date Fri, 16 May 2014 19:19:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21424/#review43244
-----------------------------------------------------------


I will defer to Niklas for a more thorough review that I can offer right now.

Thanks for following up Till. I would love to see more tests for this code!


src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/21424/#comment77341>

    What does according to the internal states mean?


- Ben Mahler


On May 16, 2014, 4:13 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21424/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 4:13 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1364
>     https://issues.apache.org/jira/browse/MESOS-1364
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> An orphaned container is known to the ECP but not to the EC, thus not recoverable but
pending. This patch enforces a call to destroy for any orphan that has been identified as
such during the recovery phase.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp afffff1 
>   src/slave/containerizer/external_containerizer.cpp 2ff19b1 
> 
> Diff: https://reviews.apache.org/r/21424/diff/
> 
> 
> Testing
> -------
> 
> make check (note that the tests currently do not cover this scenario)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message