mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 21464: Added backoff to slave's initial (re-)registration attempt.
Date Thu, 15 May 2014 18:16:21 GMT


> On May 15, 2014, 4:20 a.m., Jiang Yan Xu wrote:
> > src/slave/slave.cpp, lines 562-567
> > <https://reviews.apache.org/r/21464/diff/2-3/?file=582039#file582039line562>
> >
> >     So if a large cluster does require slave authentication, then slaves are still
going to be bombarding the master (with 1/5 load because it has a 5sec timeout but still)
and cause troubles.
> >     
> >     I think we should commit this review first but am wondering if we cut 0.19 without
this TODO implemented, whether the release can be considered stable.

It is a "scaling" issue which is not new to 0.19.0. So I think it shouldn't be a blocker for
0.19.0 release.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21464/#review43086
-----------------------------------------------------------


On May 15, 2014, 2:52 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21464/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 2:52 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1276
>     https://issues.apache.org/jira/browse/MESOS-1276
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp c0975254d51fc21dbf3bc006b3169886347f0a3f 
>   src/slave/constants.cpp 1854b16f2c1ed2ae51d2061b0338c3eda4f3b403 
>   src/slave/flags.hpp 8616817b9602f6ccf56e2af61f36c1bd295df1a1 
>   src/slave/slave.hpp 29d2a1607a2b3c4443ea14d1cc2b61a065df3cad 
>   src/slave/slave.cpp 4a8adf0efdd9a230a1f91d8d944fc6145a26b7c4 
>   src/tests/fault_tolerance_tests.cpp 4796149beb10a6c668762f5efecd86520b809c42 
>   src/tests/master_tests.cpp d74fc94dc63e169b360baac15127b03e124a7cec 
>   src/tests/mesos.cpp 7f59b72105ebf9e7d1e5e97b18d814f5ecdda50d 
>   src/tests/slave_recovery_tests.cpp 85c57b29f6a56683e0df9788dea64ebb36e00812 
>   src/tests/slave_tests.cpp 29dc7d434646998b04481e9ae6fe8589d7fed8e7 
> 
> Diff: https://reviews.apache.org/r/21464/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message