mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernardo Gomez Palacio" <bernardo.gomezpala...@gmail.com>
Subject Re: Review Request 21083: [MESOS-1259:MESOS-1294]:Enrich the Java Docs in the src/java files. -- State.java
Date Thu, 15 May 2014 05:03:02 GMT


> On May 7, 2014, 8:18 p.m., Niklas Nielsen wrote:
> > src/java/src/org/apache/mesos/state/State.java, lines 55-57
> > <https://reviews.apache.org/r/21083/diff/1/?file=574751#file574751line55>
> >
> >     Don't you want to align the @return and @param description here (and the two
other comment blocks) like in http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html?
:)

Agree, but are we all ok if I apply the same to all @return statements?


- Bernardo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21083/#review42426
-----------------------------------------------------------


On May 5, 2014, 6:36 p.m., Bernardo Gomez Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21083/
> -----------------------------------------------------------
> 
> (Updated May 5, 2014, 6:36 p.m.)
> 
> 
> Review request for mesos and Mesos ReviewBot.
> 
> 
> Bugs: MESOS-1294
>     https://issues.apache.org/jira/browse/MESOS-1294
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java
> 
> 
> Diffs
> -----
> 
>   src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8

> 
> Diff: https://reviews.apache.org/r/21083/diff/
> 
> 
> Testing
> -------
> 
> 1. ./bootstrap && mkdir build && cd build && ../configure &&
make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
> 
> 
> Thanks,
> 
> Bernardo Gomez Palacio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message