mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 21288: Allowed to get/set MTU for a link.
Date Wed, 14 May 2014 22:03:17 GMT


> On May 13, 2014, 9:41 p.m., Dominic Hamon wrote:
> > src/linux/routing/link/link.hpp, line 82
> > <https://reviews.apache.org/r/21288/diff/2/?file=579306#file579306line82>
> >
> >     MTU or getMTU to match setMTU below.

Dominic, I choose not to do that for now as it requires too much changes to the depending
patches. Also, we use mac() and setMAC(), so I'd like to be consistent for this patch. I may
want to do a cleanup to fix all these names to be:

getIP() and setIP()  (currently, it is ip() and setIP())
getMAC() and setMAC()  (currently, it is mac() and setMAC())
getMTU() and setMTU()  (currently, it is mtu() and setMTU())


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21288/#review42893
-----------------------------------------------------------


On May 13, 2014, 12:34 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21288/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 12:34 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
> 
> 
> Bugs: MESOS-1228
>     https://issues.apache.org/jira/browse/MESOS-1228
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/link/link.hpp PRE-CREATION 
>   src/linux/routing/link/link.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21288/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message