mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 20963: Add a cgroup perf_event isolator.
Date Wed, 14 May 2014 18:54:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20963/#review43000
-----------------------------------------------------------

Ship it!



src/slave/containerizer/isolators/cgroups/perf_event.cpp
<https://reviews.apache.org/r/20963/#comment76985>

    Can you pull this down after if (!exists.get()) to be consistent with how we did for other
isolators? I guess the only difference between other isolators and this one will be the absence
of 'continue' inside the if (!exists.get()).



src/slave/containerizer/isolators/cgroups/perf_event.cpp
<https://reviews.apache.org/r/20963/#comment76987>

    can you print the cgroup name too?


- Vinod Kone


On May 1, 2014, 6:42 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20963/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 6:42 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This isolator only creates the perf_event cgroup and places the executor into the cgroup;
no performance statistics are gathered/exported.
> 
> NOTE: The recover() as implemented is "non-strict"; it will happily recover containers
even if they don't have a perf_event cgroup present. This permits restarting the slave to
add this isolator. Existing containers will not be isolated. New containers will be isolated.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029 
>   src/slave/containerizer/containerizer.cpp 374a778e62321dfb57c2ad19a3614154596f4b9f

>   src/slave/containerizer/isolators/cgroups/perf_event.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20963/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> Our current testing code does not easily permit testing different combinations of isolators
for the MesosContainerizer.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message