mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 21399: Added message counters for all messages types in Master.
Date Wed, 14 May 2014 01:41:25 GMT


> On May 13, 2014, 9:02 p.m., Dominic Hamon wrote:
> > In regards to adding a layer of indirection: I'm not completely opposed to the idea,
but I'd like to avoid the tautology. So it would be:
> > 
> > master/messages/kill_task
> > master/messages/reconcile_tasks
> > master/messages/authenticate
> > 
> > 
> > what do you think?
> 
> Jiang Yan Xu wrote:
>     SGTM.

Let's think about how we'll keep consistent with naming.

My intuition tells me we should only use slashes where we want to "namespace" the metrics,
like grouping under a Process, framework or principal, etc. You could imagine the metrics
delimiter corresponds to a namespaced instance of a 'Metrics' that can be injected into components,
which would allow us to isolate metrics during testing. Meaning you give each slave a 'Metrics'
object rooted at a "UUID/" prefix so that you don't have to deal with the problem of collisions
(both slaves wanting to use "slave/*"). Likewise, you could create a namespaced 'Metrics'
under 'frameworks/jenkins' when a new Jenkins framework arrives dynamically in the Master.

If we use slashes only for "grouping" of related things, where do we draw the line in terms
of the grouping level?

master/messages/framework_registration
master/messages/framework_reregistration

vs

master/messages/framework/registration
master/messages/framework/reregistration

I think that the delimiter (slashes) would probably be best used as a namespacing mechanism
more so than a grouping mechanism for related things, since we can solve the "grouping" problem
by being consistent as Adam mentioned here: https://issues.apache.org/jira/browse/MESOS-1332

We could just use "messages_" as a prefix, and they'll group nicely:

messages_dropped
messages_kill_task
messages_register_framework
messages_reregister_framework


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21399/#review42884
-----------------------------------------------------------


On May 13, 2014, 8:59 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21399/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 8:59 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Dominic Hamon.
> 
> 
> Bugs: MESOS-1338
>     https://issues.apache.org/jira/browse/MESOS-1338
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 4f9ae36c822a16ea3baadf6b9fa3616d030d19f2 
>   src/master/master.cpp d5453673a839326d00a3d45940bd4562c526cff2 
>   src/tests/master_tests.cpp 7aa678afc94869c8243485bd0604532dec43a1e2 
> 
> Diff: https://reviews.apache.org/r/21399/diff/
> 
> 
> Testing
> -------
> 
> make check & visual verification.
> 
> The stats look like this:
> 
> {
> master/authenticate_messages: 0,
> master/deactivate_framework_messages: 0,
> master/dropped_messages: 0,
> master/event_queue_size: 0,
> master/exited_executor_messages: 0,
> master/framework_to_executor_messages: 0,
> master/kill_task_messages: 0,
> master/launch_tasks_messages: 0,
> master/reconcile_tasks_messages: 0,
> master/recovery_slave_removals: 0,
> master/register_framework_messages: 0,
> master/register_slave_messages: 0,
> master/reregister_framework_messages: 0,
> master/reregister_slave_messages: 1,
> master/resource_request_messages: 0,
> master/revive_offers_messages: 0,
> master/slave_registrations: 0,
> master/slave_removals: 0,
> master/slave_reregistrations: 1,
> master/status_update_messages: 0,
> master/unregister_framework_messages: 0,
> master/unregister_slave_messages: 0,
> registrar/queued_operations: 0,
> registrar/registry_size_bytes: 338,
> registrar/state_fetch_ms: 0.067019,
> registrar/state_store_ms: 0.26969,
> registrar/state_store_ms/count: 2,
> registrar/state_store_ms/max: 0.26969,
> registrar/state_store_ms/min: 0.031574,
> registrar/state_store_ms/p50: 0.150632,
> registrar/state_store_ms/p90: 0.2458784,
> registrar/state_store_ms/p95: 0.2577842,
> registrar/state_store_ms/p99: 0.26730884,
> registrar/state_store_ms/p999: 0.269451884,
> registrar/state_store_ms/p9999: 0.2696661884
> }
> 
> Feels like we could group message counters the following way:
> master/messages/authenticate_messages
> 
> Better?
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message