mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 21388: Added override of Flags::load that updates 'argc' and 'argv'.
Date Tue, 13 May 2014 22:09:10 GMT


> On May 13, 2014, 9:09 p.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 265
> > <https://reviews.apache.org/r/21388/diff/1/?file=580754#file580754line265>
> >
> >     Won't some compilers complain about argc not being const here?

All the other tests have this too, so we haven't run into this in practice.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21388/#review42885
-----------------------------------------------------------


On May 13, 2014, 8:14 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21388/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 8:14 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 70bd59c00fef0f4838634e85b5f35c374c671c2a

>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 9d48c16f6de07854fda31163222db093d2f5346e

> 
> Diff: https://reviews.apache.org/r/21388/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message