mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 21236: Fixed tasks reconciliation and added tests.
Date Thu, 08 May 2014 21:57:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21236/#review42540
-----------------------------------------------------------

Ship it!


Glad we found this bug!


src/master/master.cpp
<https://reviews.apache.org/r/21236/#comment76348>

    Can you s/best-effort// before you commit this?



src/master/master.cpp
<https://reviews.apache.org/r/21236/#comment76339>

    Should this say unknown as well?



src/tests/reconciliation_tests.cpp
<https://reviews.apache.org/r/21236/#comment76344>

    Hm.. status and status2 are a bit confusing, maybe s/status/update/ and s/status2/status/?
    
    Ditto below



src/tests/reconciliation_tests.cpp
<https://reviews.apache.org/r/21236/#comment76345>

    s/strict/non-strict/



src/tests/reconciliation_tests.cpp
<https://reviews.apache.org/r/21236/#comment76347>

    Could you also add a similar TODO at _reregisterSlave in master.hpp? I just want to make
sure it's clear what could be done to move it back to private :)


- Ben Mahler


On May 8, 2014, 9:09 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21236/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 9:09 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Dominic Hamon.
> 
> 
> Bugs: MESOS-1320
>     https://issues.apache.org/jira/browse/MESOS-1320
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fixed reconciliation so that status updates are always sent.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e 
>   src/master/master.cpp 87ea77aa19e482a20f081061e81acc89582eacdd 
>   src/tests/reconciliation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21236/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message