mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 21233: Abstracted out invoking 'mesos-fetcher'.
Date Thu, 08 May 2014 20:08:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21233/#review42535
-----------------------------------------------------------



src/slave/fetcher.hpp
<https://reviews.apache.org/r/21233/#comment76328>

    now this is in its own file, why not add a fetcher.cpp for the definitions and minimize
the amount of inline code + includes we have to process?



src/slave/fetcher.hpp
<https://reviews.apache.org/r/21233/#comment76329>

    this redirection could be a separate method to avoid the repeated code.


- Dominic Hamon


On May 8, 2014, 12:16 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21233/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 12:16 p.m.)
> 
> 
> Review request for mesos, Dominic Hamon, Ian Downes, Tom Arnfeld, and Vinod Kone.
> 
> 
> Bugs: MESOS-1316
>     https://issues.apache.org/jira/browse/MESOS-1316
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> To test the mesos-fetcher (and the setting of the environment) more cleanly I did some
refactoring into a 'fetcher' namespace.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029 
>   src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 
>   src/slave/containerizer/mesos_containerizer.cpp 2a4816ec34f2298b71e8591c1e92d77f94ef4cb3

>   src/slave/fetcher.hpp PRE-CREATION 
>   src/tests/containerizer_tests.cpp 9d20853bcc1965adc2d9ea41044b5613cd992f11 
>   src/tests/fetcher_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21233/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message