mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 21167: Added user field to CommandInfo.
Date Thu, 08 May 2014 19:03:46 GMT


> On May 7, 2014, 8:38 p.m., Benjamin Hindman wrote:
> > src/tests/slave_tests.cpp, lines 294-295
> > <https://reviews.apache.org/r/21167/diff/2/?file=576142#file576142line294>
> >
> >     Extra newline you probably don't want and please put a period at the end of
the comment. ;-)

Whoops - will fix. Thanks!


> On May 7, 2014, 8:38 p.m., Benjamin Hindman wrote:
> > src/tests/slave_tests.cpp, line 264
> > <https://reviews.apache.org/r/21167/diff/2/?file=576142#file576142line264>
> >
> >     If you'd like to force a MesosContainerizer you can now do that yourself with
MesosContainerizer::create which would be safer than assuming as much by setting flags.isolation
above. Same for the test below too.

Good point - thanks!


> On May 7, 2014, 8:38 p.m., Benjamin Hindman wrote:
> > src/slave/slave.hpp, line 442
> > <https://reviews.apache.org/r/21167/diff/2/?file=576140#file576140line442>
> >
> >     Commenting why we've needed to explicitly create a 'user' field would be great
because it's not obvious to me why we can't just do the following in Framework::launchExecutor
instead:
> >     
> >     string user = info.user();
> >     if (executor->info.command().has_user()) {
> >       user = executor->info.command().user();
> >     }

Right - actually, I'll just flatten as you proposed.


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21167/#review42456
-----------------------------------------------------------


On May 7, 2014, 10:59 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21167/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 10:59 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
> 
> 
> Bugs: MESOS-1141
>     https://issues.apache.org/jira/browse/MESOS-1141
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enables individual executors and tasks to run as a specific user. If
> the user field is present both in FrameworkInfo and here, the
> CommandInfo user value takes precedence.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e48e50a 
>   src/slave/slave.hpp ed20dca 
>   src/slave/slave.cpp 2a48266 
>   src/tests/slave_tests.cpp 0982455 
> 
> Diff: https://reviews.apache.org/r/21167/diff/
> 
> 
> Testing
> -------
> 
> make check as root on Linux. Tests are guarded/only run when running
> as root as the containerizer needs to execute chown.  Running tests as
> root on Mac OS X is currently broken.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message