mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.
Date Wed, 07 May 2014 09:20:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20958/#review42390
-----------------------------------------------------------


Bad patch!

Reviews applied: [20816]

Failed command: git apply --index 20816.patch

Error:
 error: patch failed: src/slave/containerizer/linux_launcher.hpp:38
error: src/slave/containerizer/linux_launcher.hpp: patch does not apply
error: patch failed: src/slave/containerizer/linux_launcher.cpp:16
error: src/slave/containerizer/linux_launcher.cpp: patch does not apply


- Mesos ReviewBot


On May 1, 2014, 5:26 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20958/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 5:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> We *may* have observed deadlocks in the forked child when testing some other new code
so this makes the execute() function in MesosContainerizer completely async-signal safe.
> 
> Reviewers: I'd appreciate it if you could carefully check that I've made this completely
async signal safe.
> 
> 
> Replace all stout calls with just the appropriate system call.
> 
> Construct Envp and pass into child and use execle for the environment.
> 
> Use open and dup2 rather than freopen.
> 
> Determine gid and uid and pass into child.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos_containerizer.cpp df57e5443d0e3a94588464d83822ed5e3e9f88ea

> 
> Diff: https://reviews.apache.org/r/20958/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message