mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 19965: Enabled whitespace/semicolon rule for cpplint.
Date Tue, 06 May 2014 10:44:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19965/#review42268
-----------------------------------------------------------


Patch looks great!

Reviews applied: [19965]

All tests passed.

- Mesos ReviewBot


On May 6, 2014, 8:06 a.m., Adam B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19965/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 8:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Bugs: MESOS-1181
>     https://issues.apache.org/jira/browse/MESOS-1181
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enabled whitespace/semicolon rule for cpplint, which covers the following logic:
> # You should always have a space after a semicolon
> # except for few corner cases
> 
> # You shouldn't have a space before a semicolon at the end of the line.
> # There's a special case for "for" since the style guide allows space before
> # the semicolon there.
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp 5f674cd 
>   support/mesos-style.py bd7dcdb 
> 
> Diff: https://reviews.apache.org/r/19965/diff/
> 
> 
> Testing
> -------
> 
> Ran mesos-style.py over entire source base with whitespace/semicolon enabled.
> $ support/mesos-style.py
> Checking 424 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
> Total errors found: 0
> 
> 
> Thanks,
> 
> Adam B
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message