mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 21013: Addition of DynamicLibrary to stout.
Date Tue, 06 May 2014 03:36:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21013/#review42242
-----------------------------------------------------------


Bad patch!

Reviews applied: [21013]

Failed command: ./support/mesos-style.py

Error:
 Checking 426 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/tests/cgroups_tests.cpp:829:  Lines should be <= 80 characters long  [whitespace/line_length]
[2]
Total errors found: 1


- Mesos ReviewBot


On May 6, 2014, 3:07 a.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21013/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 3:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1224
>     https://issues.apache.org/jira/browse/MESOS-1224
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Addition of DynamicLibrary class to stout, to enable future plugins inside of mesos.

> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 980146b 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am aa1d0a5 
>   3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/configure.ac 0c7cc6d 
> 
> Diff: https://reviews.apache.org/r/21013/diff/
> 
> 
> Testing
> -------
> 
> New test has been added and ran 'make check' around Mac and Linux
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message