mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 20983: Update system check (http-parser)
Date Sat, 03 May 2014 02:47:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20983/#review42083
-----------------------------------------------------------

Ship it!


Take one down, pass it around, 99 libraries left to unbundle. ;-)


3rdparty/libprocess/Makefile.am
<https://reviews.apache.org/r/20983/#comment75835>

    FYI, I like pulling these into the 'if' blocks but we did not do this with the previous
unbundling patches for ZooKeeper and LevelDB so we might want to revisit that to be consistent.



3rdparty/libprocess/Makefile.am
<https://reviews.apache.org/r/20983/#comment75832>

    We haven't been as consistent as we've liked here, but when we wrap let's start on a newline
and let's indent by +2 (see how we did it above for libprocess_la_LIBADD).



3rdparty/libprocess/Makefile.am
<https://reviews.apache.org/r/20983/#comment75831>

    This is a weird one, but we use tabs here rather than spaces as most editors will align
'\' correctly with tabs but not with spaces.



3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/20983/#comment75836>

    Okay, so this is my fault but I missed this +4 indentation in the previous patches even
though we had +2 everywhere else in these files. I've since fixed the +2 indentation from
the previous patches as part of the whitespace/indent work that Adam and I did earlier this
week but please let's do +2 going forward (also below in this file, and spaces not tabs please).



3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/20983/#comment75830>

    Please wrap within 80 characters (this should now be caught with mesos-style.py):
    
    AM_CONDITIONAL([WITH_BUNDLED_HTTP_PARSER], 
                   [test "x$with_bundled_http_parser" = "xyes"])


- Benjamin Hindman


On May 1, 2014, 9:15 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20983/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 9:15 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1175
>     https://issues.apache.org/jira/browse/MESOS-1175
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Updates libprocess configure check for http-parser to build against system dependencies
outlined in MESOS-1071
> + fixes libprocess local 'make check' which was broken
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 8ccf0ef 
>   3rdparty/libprocess/Makefile.am 8990f38 
>   3rdparty/libprocess/configure.ac fc5e2ad 
> 
> Diff: https://reviews.apache.org/r/20983/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message