mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 19545: Ported libprocess system/stats.json endpoint to new metrics library.
Date Fri, 02 May 2014 19:15:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545/
-----------------------------------------------------------

(Updated May 2, 2014, 12:15 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

fixed to work for more than just clang
changed metrics tests that check JSON as the libprocess metrics show up there now. as such
we can't make assumptions about it being empty at the start of the test.


Bugs: MESOS-1146
    https://issues.apache.org/jira/browse/MESOS-1146


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/include/process/system.hpp fbd1eaa1de44eb419cef4c78efd6d138eabc7b44

  3rdparty/libprocess/src/tests/metrics_tests.cpp 75f1f0e35fdb1ec707785d1ebb903af99551bdaa


Diff: https://reviews.apache.org/r/19545/diff/


Testing
-------

make check and manually checked /system/stats.json against /metrics


Thanks,

Dominic Hamon


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message