mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 20971: Update process::reap to use os::exists(pid).
Date Fri, 02 May 2014 01:01:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20971/#review41994
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/src/reap.cpp
<https://reviews.apache.org/r/20971/#comment75721>

    do we need errno == ECHILD check here?


- Vinod Kone


On May 1, 2014, 7:18 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20971/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 7:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/reap.cpp 274d1292a596c64de58e0b30e3d6a465bbf11e17 
> 
> Diff: https://reviews.apache.org/r/20971/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message