mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 20934: Ignored the log write request to a position if it has already been learned.
Date Fri, 02 May 2014 00:46:13 GMT


> On May 2, 2014, 12:21 a.m., Ben Mahler wrote:
> > src/log/replica.cpp, lines 579-595
> > <https://reviews.apache.org/r/20934/diff/1/?file=572042#file572042line579>
> >
> >     Is this TODO still relevant or can it now be a NOTE to complement your comment
above, because we're now handling it properly?
> >     
> >     In other words, is there something left "to do" here?

Changed it to NOTE.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20934/#review41983
-----------------------------------------------------------


On May 1, 2014, 12:36 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20934/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 12:36 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1271
>     https://issues.apache.org/jira/browse/MESOS-1271
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/replica.cpp d566b24 
> 
> Diff: https://reviews.apache.org/r/20934/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message