mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 20934: Ignored the log write request to a position if it has already been learned.
Date Fri, 02 May 2014 00:21:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20934/#review41983
-----------------------------------------------------------

Ship it!



src/log/replica.cpp
<https://reviews.apache.org/r/20934/#comment75700>

    Is this TODO still relevant or can it now be a NOTE to complement your comment above,
because we're now handling it properly?
    
    In other words, is there something left "to do" here?


- Ben Mahler


On May 1, 2014, 12:36 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20934/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 12:36 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1271
>     https://issues.apache.org/jira/browse/MESOS-1271
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/replica.cpp d566b24 
> 
> Diff: https://reviews.apache.org/r/20934/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message