Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7773C11744 for ; Fri, 25 Apr 2014 00:53:42 +0000 (UTC) Received: (qmail 38830 invoked by uid 500); 25 Apr 2014 00:53:41 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 38783 invoked by uid 500); 25 Apr 2014 00:53:41 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 38773 invoked by uid 99); 25 Apr 2014 00:53:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2014 00:53:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0BF611D70EE; Fri, 25 Apr 2014 00:53:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7656743041678492845==" MIME-Version: 1.0 Subject: Re: Review Request 20119: Updated policy for building against system dependencies. From: "Timothy St. Clair" To: "Benjamin Hindman" Cc: "Timothy St. Clair" , "Mesos ReviewBot" , "mesos" Date: Fri, 25 Apr 2014 00:53:35 -0000 Message-ID: <20140425005335.5212.33832@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Timothy St. Clair" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/20119/ X-Sender: "Timothy St. Clair" References: <20140424184808.21392.66844@reviews.apache.org> In-Reply-To: <20140424184808.21392.66844@reviews.apache.org> Reply-To: "Timothy St. Clair" X-ReviewRequest-Repository: mesos-git --===============7656743041678492845== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20119/ ----------------------------------------------------------- (Updated April 25, 2014, 12:53 a.m.) Review request for mesos and Benjamin Hindman. Changes ------- switch inner test from == -> = Bugs: MESOS-1071 and MESOS-1168 https://issues.apache.org/jira/browse/MESOS-1071 https://issues.apache.org/jira/browse/MESOS-1168 Repository: mesos-git Description ------- Allows preventing the use of bundled libraries in favor of preinstalled versions, where possible. --disable-bundled generally switches from bundled to preinstalled libraries. If --disable-bundled is supplied or --with-leveldb[=DIR] was given but the configuration phase could not locate the dependency, it stops with an error. If --disable-bundled is not supplied and no --with-leveldb[=DIR] was given, the bundled library is built and used (DEFAULT). NOTE: 1. This review only implements this preinstalled library usage on LevelDB & ZooKeeper. Subsequent review requests for other bundled libraries will follow as soon as this implementation has been accepted. 2. This modification removed the old --without-installed-PACKAGE semantics, as they conflict with well established --with-PACKAGE semantics Diffs (updated) ----- 3rdparty/Makefile.am 23ff1fa configure.ac 570eb4b src/Makefile.am 9716cfd src/python/setup.py.in 02f00ef Diff: https://reviews.apache.org/r/20119/diff/ Testing ------- make check across all combinatoric incantations. Thanks, Timothy St. Clair --===============7656743041678492845==--