Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EF8AC10DA5 for ; Fri, 11 Apr 2014 20:02:27 +0000 (UTC) Received: (qmail 24588 invoked by uid 500); 11 Apr 2014 20:02:26 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 24195 invoked by uid 500); 11 Apr 2014 20:02:25 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 24164 invoked by uid 99); 11 Apr 2014 20:02:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Apr 2014 20:02:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 161761D5E48; Fri, 11 Apr 2014 20:02:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5069322498986705071==" MIME-Version: 1.0 Subject: Re: Review Request 19487: Change linkage around libjvm to use dlopen. From: "Timothy St. Clair" To: "Niklas Nielsen" , "Benjamin Hindman" , "Till Toenshoff" Cc: "Timothy St. Clair" , "mesos" , "Mesos ReviewBot" , "Vinod Kone" Date: Fri, 11 Apr 2014 20:02:15 -0000 Message-ID: <20140411200215.10503.97084@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Timothy St. Clair" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/19487/ X-Sender: "Timothy St. Clair" References: <20140411163402.25249.63453@reviews.apache.org> In-Reply-To: <20140411163402.25249.63453@reviews.apache.org> Reply-To: "Timothy St. Clair" X-ReviewRequest-Repository: mesos-git --===============5069322498986705071== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19487/ ----------------------------------------------------------- (Updated April 11, 2014, 8:02 p.m.) Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Till Toenshoff. Changes ------- Updated patch per review Bugs: MESOS-1126 https://issues.apache.org/jira/browse/MESOS-1126 Repository: mesos-git Description ------- The dependency on libjvm is a "hard", requiring an link and rpath. This causes issues when shifting between jvms. The standard practice is to use dlopen against the $JAVA_JVM_LIBRARY location. MESOS-1126 + Enable dlopen for libjvm.so + Cleanup redundant jni inclusions This should make MESOS-855 a non-issue. Diffs (updated) ----- configure.ac c1de6d7 src/Makefile.am 95f133d src/common/build.hpp 115e9cc src/common/build.cpp eed08ed src/jvm/jvm.cpp d3dfa75 Diff: https://reviews.apache.org/r/19487/diff/ Testing ------- make check (across both Mac and Linux) Thanks, Timothy St. Clair --===============5069322498986705071==--